internal(browser): Add Click action support to Browser Test Editor#1156
Merged
going-confetti merged 2 commits intomainfrom Apr 9, 2026
Merged
internal(browser): Add Click action support to Browser Test Editor#1156going-confetti merged 2 commits intomainfrom
going-confetti merged 2 commits intomainfrom
Conversation
going-confetti
commented
Apr 9, 2026
| @@ -76,6 +76,13 @@ function NewActionMenu({ onAddAction }: NewActionMenuProps) { | |||
| </Button> | |||
| </DropdownMenu.Trigger> | |||
| <DropdownMenu.Content> | |||
Collaborator
Author
There was a problem hiding this comment.
As more actions get added, we'll need to use something better than a simple dropdown menu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How to Test
Checklist
Related PR(s)/Issue(s)
Note
Medium Risk
Adds a new action type that affects browser test script generation and editor behavior; mistakes could produce incorrect or non-functional generated tests, though scope is limited and options are currently hardcoded.
Overview
Adds basic
locator.clicksupport end-to-end in the Browser Test Editor.The editor can now create and edit a new “Click element” action (new
ClickActionBody, menu item, and registry entry with icon) and uses a sharedcreateDefaultLocatorOptions()helper for default locator initialization.Code generation (
convertActionsToTestinsrc/codegen/browser/test.ts) now convertslocator.clickactions intoclicktest nodes with default left-button and no-modifier settings.Reviewed by Cursor Bugbot for commit 21ab714. Bugbot is set up for automated code reviews on this repo. Configure here.